AKHIL SHARMA comments

Results 9 comments of


                                            AKHIL SHARMA

Fix the Bug in `pybamm.QuickPlot.py`

> > 3. pybamm.QuickPlot.get_spatial_var made private. > > This will require a note in the CHANGELOG too as a breaking change (even if this function was not being used by...

Fix the Bug in `pybamm.QuickPlot.py`

> @Akhil-Sharma30 Just a note, I would suggest that you don't force push if you can avoid it. It overwrites history on git and makes it harder to see what...

Fix the Bug in `pybamm.QuickPlot.py`

> @Akhil-Sharma30 Are you still working on this and #3752 Yes, I was busy with some other work.

[Bug]: `pybamm.Simulation.set_parameters`, `pybamm.Simulation.set_up_and_parameterise_experiment` and `pybamm.Simulation.set_up_and_parameterise_model_for_experiment` made private in `simulation.py`

> You will need to also update the method names wherever they are called (which should only be inside the `Simulation` class) Done.

[Bug]: `pybamm.Simulation.set_parameters`, `pybamm.Simulation.set_up_and_parameterise_experiment` and `pybamm.Simulation.set_up_and_parameterise_model_for_experiment` made private in `simulation.py`

> Ideally, we should deprecate these functions before making them private, given that they are visible in the API docs, but this might be fine if not a lot of...

[Bug]: `pybamm.Simulation.set_parameters`, `pybamm.Simulation.set_up_and_parameterise_experiment` and `pybamm.Simulation.set_up_and_parameterise_model_for_experiment` made private in `simulation.py`

I am not able to reset my branch I made a mess of it. Could someone provide me instruction on how to fix this issue?

[Bug]: `pybamm.Simulation.set_parameters`, `pybamm.Simulation.set_up_and_parameterise_experiment` and `pybamm.Simulation.set_up_and_parameterise_model_for_experiment` made private in `simulation.py`

> > I am not able to reset my branch I made a mess of it. Could someone provide me instruction on how to fix this issue? > > Can...

[Bug]: `pybamm.Simulation.set_parameters`, `pybamm.Simulation.set_up_and_parameterise_experiment` and `pybamm.Simulation.set_up_and_parameterise_model_for_experiment` should be private (i.e. begin with underscore _) and not documented

I would like to work on this issue.

Make code blocks in `src/vector/_compute/*.py` parsable

Can I work on this issue?