der richter
der richter
if i had the time i would, but i don't have any atm.
if we want to use the `localizedName` if the `displayName` is not available we also need to adjust the retrieval for the `display-names` property. since they should match. this part...
if the `localizedName` is the new official way to retrieve the display name now, we should replace all the usages of `displayName` with `localizedName`. i only added `displayName` since there...
you can completely remove the code from `osdep/macos/swift_extensions.swift`, the one for the displayName i mean. also i think the macOS detection for macOS versions after 10.15 can be simplified. something...
the compile time check won't work like that. mpv build with SDK 10.15 but min system set to 10.14 for example will fail, since the `localizedName` is not available. sry...
> https://github.com/mpv-player/mpv/blob/5186651f304fb49867f2542d2eb149f8191cf0de/osdep/macos/swift_extensions.swift#L47 > > `info[kDisplaySerialNumber]` is `nil` but `CGDisplaySerialNumber(displayID)` is not `0`. I'm not sure why that is. Maybe because it's an old DVI monitor. would you mind telling what...
there are a few things i still need to think about and some possible changes. though i am currently short on time.
we have some contribution rules here https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md, like commit message and body. the problem and explanation should be part of the commit body.
on my end with `--video-sync=display-resample` at least the glitch is gone. audio still starts late or rather the video starts too early compared to vlc or quicktime. what i observed...
i added a few comments. it would also be nice to have some mpv option examples and some screenshots with before, now and quicktime. mostly out of curiosity and for...