mpv icon indicating copy to clipboard operation
mpv copied to clipboard

audio/format: fix Type 'struct entry' has incompatible definitions in different translation units

Open Coeur opened this issue 3 years ago • 1 comments
trafficstars

When using Xcode, struct entry already exists (from <search.h>), so the one we declare in audio/format.c needs to be named differently.

Coeur avatar Aug 29 '22 14:08 Coeur

we have some contribution rules here https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md, like commit message and body. the problem and explanation should be part of the commit body.

Akemi avatar Aug 29 '22 17:08 Akemi

@Akemi can we get a review? Thanks

Coeur avatar Oct 09 '22 16:10 Coeur

Sorry for nitpicking but internal types are usually named mp_thing not mpv_thing. Looks good other than that.

sfan5 avatar Oct 23 '22 10:10 sfan5

@sfan5 OK, renamed. Good to merge. :)

Coeur avatar Oct 23 '22 12:10 Coeur