Craigory Coppola comments

Results 130 comments of


Craigory Coppola

fast-glob doesn't match list segments correctly

Hey @mrmlnc! Just checking in on this again. If someone can point me to the right spot to start making changes I'd be happy to investigate this a bit further...

fast-glob doesn't match list segments correctly

I repro'd on the picomatch repo and opened an issue there, hoping to accelerate this one too. Let me know if there is anything else from my side that could...

fast-glob doesn't match list segments correctly

Awesome! Thanks for the fix @mrmlnc! Happy maintainers month, hoping things are well for you.

Allow targetDefaults dependsOn to specify a package

Ah, yeah it should have been. Thanks.

fix(core): use relative paths for socket path

I'm admin merging this - Circle has a green check, just not reporting to github for some reason 🤷

feat(core): add --only option to nx affected

Hey @AlexJWayne! This PR has gone a while without comment from us, unfortunately. Looking at this now, I'm not sure that we would want to add this flag, and feel...

Outdated Configurations Run Command

It appears this has been fixed as docs have been updated over time.

feat(js): fine-grained dep type support for publishable libs

Hey @mckramer! This PR has been sitting around for a bit. I have some concerns with using '[inherit]' as a version token inside the project's package.json, as if a workspace...

feat(core): be able to depend on a configuration of a target

This is made a bit complex by the edge cases when depending on different configurations of the same target etc, I'll talk it over with @FrozenPandaz and see his thoughts.

run-commands cuts last line of inquirer output/console output

This should be fixed with the native comand runner in Nx 17.3. I'm going to go ahead with closing this out as the associated work has been merged.