nx icon indicating copy to clipboard operation
nx copied to clipboard

feat(core): be able to depend on a configuration of a target

Open dmitry-stepanenko opened this issue 2 years ago • 9 comments

Current Behavior

Right now dependsOn syntax allows to specify only the name of the target. However, there're certain scenarios where it would be beneficial to have an ability to depend on a certain configuration of this target

Expected Behavior

See details here https://github.com/nrwl/nx/issues/15064

Related Issue(s)

Fixes https://github.com/nrwl/nx/issues/15064

dmitry-stepanenko avatar Feb 25 '23 19:02 dmitry-stepanenko

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 25, 2023 at 7:35PM (UTC)

vercel[bot] avatar Feb 25 '23 19:02 vercel[bot]

@vsavkin @FrozenPandaz @AgentEnder @juristr any update on this one?

dmitry-stepanenko avatar Mar 11 '23 10:03 dmitry-stepanenko

This is made a bit complex by the edge cases when depending on different configurations of the same target etc, I'll talk it over with @FrozenPandaz and see his thoughts.

AgentEnder avatar May 01 '23 14:05 AgentEnder

@AgentEnder hello, any updates here?

temarusanov avatar Jul 06 '23 09:07 temarusanov

@AgentEnder also looking for updates on this one. Seems like an awesome feature to have!

tnrich avatar Jul 13 '23 21:07 tnrich

@AgentEnder @FrozenPandaz Could you share any updates on this? Are you still considering this approach, or is it a no-go, and we shouldn't expect it in future releases? I got pretty confused when dependsOn: ["build:development"] didn't work out of the box. Also, the changes from the pull request are hidden behind the nx-accept-same-target-variations flag, so they shouldn't (theoretically) mess up anything in existing projects.

SebastianSedzik avatar Dec 19 '23 22:12 SebastianSedzik

Is there any updates on this? Would be very useful!

illyakaynov avatar Jan 08 '24 09:01 illyakaynov

Can someone review this please?

ciriousjoker avatar Feb 17 '24 16:02 ciriousjoker

@vsavkin @FrozenPandaz @AgentEnder @juristr @Cammisuli sorry to spam y'all but can we please get this in?

tnrich avatar Apr 01 '24 21:04 tnrich

Would love to see this in the next version, big hassle not having it

gabrielbryk avatar May 30 '24 23:05 gabrielbryk

I hate closing this out after so long, but I believe that its the best next step. Sorry for dragging this out @dmitry-stepanenko - your contributions are appreciated. See more detail in the linked issue, which we are leaving open.

AgentEnder avatar Jul 24 '24 21:07 AgentEnder

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

github-actions[bot] avatar Jul 30 '24 00:07 github-actions[bot]