nx
nx copied to clipboard
feat(core): be able to depend on a configuration of a target
Current Behavior
Right now dependsOn syntax allows to specify only the name of the target. However, there're certain scenarios where it would be beneficial to have an ability to depend on a certain configuration of this target
Expected Behavior
See details here https://github.com/nrwl/nx/issues/15064
Related Issue(s)
Fixes https://github.com/nrwl/nx/issues/15064
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| nx-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 25, 2023 at 7:35PM (UTC) |
☁️ Nx Cloud Report
CI is running/has finished running commands for commit c55c6127ba906a434ff6fbadb9fd0c7663624b9f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this branch
✅ Successfully ran 8 targets
nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detoxnx affected --target=e2e --base=15019cfcecf13ab885ede51c324dca8c7ebacda0 --head=c55c6127ba906a434ff6fbadb9fd0c7663624b9f --exclude=e2e-storybook,e2e-storybook-angular --parallel=1nx affected --target=test --base=15019cfcecf13ab885ede51c324dca8c7ebacda0 --head=c55c6127ba906a434ff6fbadb9fd0c7663624b9f --parallel=1nx affected --target=build --base=15019cfcecf13ab885ede51c324dca8c7ebacda0 --head=c55c6127ba906a434ff6fbadb9fd0c7663624b9f --parallel=3nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dtenx affected --target=lint --base=15019cfcecf13ab885ede51c324dca8c7ebacda0 --head=c55c6127ba906a434ff6fbadb9fd0c7663624b9f --parallel=3nx-cloud record -- nx format:check --base=15019cfcecf13ab885ede51c324dca8c7ebacda0 --head=c55c6127ba906a434ff6fbadb9fd0c7663624b9fnx documentation --no-dte
Sent with 💌 from NxCloud.
@vsavkin @FrozenPandaz @AgentEnder @juristr any update on this one?
This is made a bit complex by the edge cases when depending on different configurations of the same target etc, I'll talk it over with @FrozenPandaz and see his thoughts.
@AgentEnder hello, any updates here?
@AgentEnder also looking for updates on this one. Seems like an awesome feature to have!
@AgentEnder @FrozenPandaz Could you share any updates on this? Are you still considering this approach, or is it a no-go, and we shouldn't expect it in future releases? I got pretty confused when dependsOn: ["build:development"] didn't work out of the box.
Also, the changes from the pull request are hidden behind the nx-accept-same-target-variations flag, so they shouldn't (theoretically) mess up anything in existing projects.
Is there any updates on this? Would be very useful!
Can someone review this please?
@vsavkin @FrozenPandaz @AgentEnder @juristr @Cammisuli sorry to spam y'all but can we please get this in?
Would love to see this in the next version, big hassle not having it
I hate closing this out after so long, but I believe that its the best next step. Sorry for dragging this out @dmitry-stepanenko - your contributions are appreciated. See more detail in the linked issue, which we are leaving open.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.