AGLint

AGLint copied to clipboard

- For example, in the following case, the rule is valid, so the disable comment is unnecessary: ```adblock ! aglint-disable-next-line example.com##.ad ``` ↓↓↓ should be fixed as ↓↓↓ ```adblock example.com##.ad...

scripthunter7

The CLI currently accepts relative and absolute paths, such as: ``` $ aglint file1.txt file2.txt subdir/file3.txt D:\work\my-filters\filter.txt ``` In the future, we can supplement this with glob patterns, such as...

scripthunter7

I suggest implementing debug mode. If we pass the `--debug` flag to the CLI, it should print everything to the console in detail so that the config building, scanning, walking,...

scripthunter7

Currently, supported directive names, hints and platforms are [just burned](https://github.com/AdguardTeam/AGLint/blob/31c3ab68f2fddb8515451a762e899ad3c823529d/src/linter/rules/unknown-hints-and-platforms.ts#L18-L30) into these rules. It would be good to make them configurable, for example like this: ```yaml rules: unknown-hints-and-platforms: ["error", {...

scripthunter7

I suggest considering the implementation of Coveralls integration. References: - https://coveralls.io/ - https://coveralls.io/github/badges/shields - https://github.com/marketplace/actions/coveralls-github-action

scripthunter7

We're relaxing validation rules in tsurlfilter and CoreLibs: https://github.com/AdguardTeam/CoreLibs/issues/1816 But it still makes sense to validate if a filtering rule match "too many" URLs. Please take a look at the...

ameshkov

Currently, [`lint`](https://github.com/AdguardTeam/AGLint/blob/aee21dbcad3e2d07c054293a501cca071b07dfd7/src/linter/index.ts#L573) method only accepts raw filter lists as parameters, but it would be nice to improve it in such a way that it also accepts AGTree filter list nodes...

scripthunter7

Add a linter rule that checks whether the domain is alive or not

1

We can use `urlfilter.adtidy.org` to quickly check whether a domain is alive or not. Here's how it can be done: `https://urlfilter.adtidy.org/v2/checkDomains?domain=doubleclick.net&domain=doubleclick.com` The response will contain this structure: ``` "info": {...

ameshkov

We should add `lint-staged` to the integration docs: https://github.com/AdguardTeam/AGLint/blob/master/docs/repo-integration.md Reference: https://github.com/okonet/lint-staged

scripthunter7

AGLint does not know about "Protected Audience API" permissions

2

https://github.com/AdguardTeam/AdguardFilters/commit/01eba10fd508fa170dd02c93b1db7fa88c621004 This rule is getting flagged: `$permissions=join-ad-interest-group=()\, run-ad-auction=()\, browsing-topics=()`

ameshkov