Adam Gleave

Results 172 comments of Adam Gleave

Bump -- did https://github.com/HumanCompatibleAI/imitation/pull/546 resolve this? I'll close this soon if I don't hear back.

From a quick skim this does indeed seem redundant and these methods could probably be removed now. @Rocamonde do you mind making a PR to address this issue?

We removed the logic to save normalization statistics long before we added support for Hugging Face, so I'm confused by this. I suspect the error message may be misleading in...

I can't replicate this error: ```bash $ python -m imitation.scripts.eval_policy with seals_ant INFO - eval_policy - Running command 'eval_policy' INFO - eval_policy - Started run with ID "177" INFO -...

Is the `huggingface-sb3` package the same version?

Hm, well it does indeed appear that `vec_normalize.pkl` is present in the HuggingFace repo: https://huggingface.co/HumanCompatibleAI/ppo-seals-Ant-v0/tree/main I'm frankly a bit confused by this. Searching for `vec_normalize.pkl` in `rl-baselines3-zoo` doesn't find anything...

Thanks @taufeeque9! Unfortunately although just ignoring `vec_normalize.pkl` avoids a runtime error, there's still the issue that `imitation` then is just not using the normalization stats at all. I think we...

@levmckinney let me know if there's any particular areas you'd like my feedback on, I'll aim to try and do a high-level review but may not have time to look...

> When reading through the logging code, I see we are maintaining a somewhat advanced and general logging infrastructure for hierarchical logging. I'm surprised there's not an already existing way...

@Rocamonde I think Lev requested re-review, could you take another look soon? Thanks!