Adam Gleave

Looks like you've addressed most of my and Juan's suggestions -- please just request re-review from us once you've made all changes you want to in this PR.

@Rocamonde do you have any more comments? (If not I think we can merge.)

https://codecov.io/gh/HumanCompatibleAI/imitation/commit/f6e2925f6342de8916009aae8370f1f4bb58b4c9/ is showing it, so it seems to have just not reported status to GitHub. I've made an empty commit to re-trigger it, will see if that works.

> Looks like that worked. The reduction in test coverage at https://app.codecov.io/gh/HumanCompatibleAI/imitation/compare/519/changes seems to be driven by: - forward of BasicPotentialCNN not being tested. We should probably add a test...

CodeCov is passing now after the merge (which I screwed up but fixed). I think CodeCov sometimes gets confused when the base isn't the most recent version of master.

> The first issue is with the helpers in `imitation.policies.serialize`. They impose a format in which the model is always stored in a file called `model.zip` which is not compatible...

> Concerning demonstrations: I agree we still want to load demonstrations from disk. Right now there is no canonical way to upload RL-demonstrations to huggingface hub but there is the...

> > What command can I run to replicate this failure? In CircleCI logs I see some scripts failing, but nothing that seemed preference comparison specific. > > Seems like...

> What was it initially supposed to do? It seems to abort the script when some log files don't include the term "Result". But what is the consequence? What does...

> I can easily make the `test_convert_trajs_in_place` case pass by adding back the demonstrations (`final.pkl`) in the testdata folder. However, I figured out that the `final.pkl` in the current master...