Adam Wรณjcik

Results 1119 comments of Adam Wรณjcik

ok I updated the spec @waldekmastykarz, @martinlingstuyl what do you think about it now?

> I'm actually using `helpMode` for #3782 ๐Ÿ˜„ How about `helpTarget`? done โœ…

@pnp/cli-for-microsoft-365-maintainers any other remarks or should we open this up ?

Ready to merge ๐Ÿš€ after next minor release @MathijsVerbeeck awesome work. I will do a small fixup when merging and resolve the conflicts as well

@martinlingstuyl looks really promising ๐Ÿ‘ I think it will be a significant improvement in the codebase ๐Ÿ’ช. checked locally โœ… ![image](https://github.com/pnp/cli-microsoft365/assets/58668583/30836856-f795-4cad-9199-88b23049cf92) @pnp/cli-for-microsoft-365-maintainers what do you think? I am all in...

> @Adam-it : Thanks for the awesome review, I learn a lot from the coding reviews. Hopefully I will finish reviewing all comments soon. No rush. Once again thank you...

@reshmee011 I added a few more comments (mostly tiny details) ๐Ÿ‘. Please double-check that GitHub tends to collapse comments so it's easy to overlook them and I suspect that is...

@reshmee011 I rechecked your question with the `CommandError` and left the comment for it. Basically it was all ok and I failed to notice we are already hanling it ok....

Ready to merge ๐Ÿš€ I should resolve one small comment when merging