cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

add more options to spo user remove. closes #5522

Open reshmee011 opened this issue 1 year ago β€’ 5 comments

Closes #5522

reshmee011 avatar Jan 30 '24 09:01 reshmee011

Thank you @reshmee011, we'll try to review it ASAP!

milanholemans avatar Jan 30 '24 12:01 milanholemans

@milanholemans , many thanks, not sure whether I have handled the additional options in the best possible way , it will good to have someone's else opinion.

reshmee011 avatar Jan 30 '24 12:01 reshmee011

@Adam-it : Thanks for the awesome review, I learn a lot from the coding reviews. Hopefully I will finish reviewing all comments soon.

reshmee011 avatar Feb 12 '24 07:02 reshmee011

@Adam-it : Thanks for the awesome review, I learn a lot from the coding reviews. Hopefully I will finish reviewing all comments soon.

No rush. Once again thank you for sticking with us πŸ‘πŸ€™. Let me know if you need any kind of help πŸ™‚

Adam-it avatar Feb 12 '24 07:02 Adam-it

@Adam-it : If I don't finish the review today, it will only over the weekend I might be able to work it as it is half term this week (school holidays for the girls) and my brother-in-law's wedding on Wednesday.

reshmee011 avatar Feb 12 '24 07:02 reshmee011

@reshmee011 I added a few more comments (mostly tiny details) πŸ‘. Please double-check that GitHub tends to collapse comments so it's easy to overlook them and I suspect that is what happened also last time as I noticed 2 comments were not resolved (no problem with thatπŸ‘) image

As always let me know if you need any help or if something is not clear πŸ™‚

Adam-it avatar Feb 29 '24 01:02 Adam-it

@reshmee011 I rechecked your question with the CommandError and left the comment for it. Basically it was all ok and I failed to notice we are already hanling it ok. As for the progress I see we still have some unresolved comments? Do you need any help from my side on those? Once again sorry for the hold up from my side πŸ™

Adam-it avatar Mar 08 '24 22:03 Adam-it

@Adam-it : I fell victim to the collapsed comment sections failing to resolve all. I think I have handled them all now. Sorry about this, I know it can frustrating to repeat the same thing. You are awesome and I have learned a lot from your comments and your demo during the community call. Don't worry about the delay, the most important is to get it right.

reshmee011 avatar Mar 08 '24 23:03 reshmee011

Ready to merge πŸš€ I should resolve one small comment when merging

Adam-it avatar Mar 09 '24 23:03 Adam-it

Merged manually πŸ‘ Awesome work πŸ‘

Adam-it avatar Mar 11 '24 00:03 Adam-it