Adam Wójcik comments

Results 1119 comments of


                                            Adam Wójcik

Sample script: get report for SharePoint add-ins and azure acs retirement

@mkm17 we have a guide how to properly add a script sample for our repo https://pnp.github.io/cli-microsoft365/contribute/script-sample/new-script-sample you may go over the steps and the structure and double check if it...

Signing in through a federated identity

Sorry for coming late to the party. I love the idea and I think it is an awesome improvement that might support pipelines so I am all in on that....

Signing in through a federated identity

> Hi @Adam-it, we first need to decide the route we'll take. If we use the accessToken approach I'm mentioning above, we'll definitely have to implement it in the CLI...

Signing in through a federated identity

ok gotcha 👍

New sample script: Script to generate the retirement report of SharePoint Add-Ins and Azure ACS. Closes #5774.

Ready to merge 🚀 Correct the title before merging

New sample script: Script to generate the retirement report of SharePoint Add-Ins and Azure ACS. Closes #5774.

Merged manually 👍 Awesome work 👏

Centralize some code used in tests

> ```ts > includeDefaultBeforeEachHookSetup(); > includePromptStub(); > ``` @martinlingstuyl I think that's a good idea but let's not make it too granular. Otherwise we will get back to the point...

Refactor `spo page set` and `spo page add` to use util instead of calling other command, Closes #5300

Thanks for another awesome PR 💪👍. You are on 🔥 today. We will review it ASAP

Refactor `spo page set` and `spo page add` to use util instead of calling other command, Closes #5300

@nicodecleyre also here some tests are failing and it does not seem like some workflow glitch 😉. could you recheck locally?

Refactor `spo page set` and `spo page add` to use util instead of calling other command, Closes #5300

Will check this one as well. I think it is related to the other PR