pnp
New sample script: Script to generate the retirement report of SharePoint Add-Ins and Azure ACS. Closes #5774.
#5774 Script to generate the retirement report of SharePoint Add-Ins and Azure ACS
- Adds a new script to generate the retirement report of SharePoint Add-Ins and Azure ACS. Closes #5774
Linked Issue #5774
Hi everyone, I managed to create the script mentioned in the initial issue. I am looking forward to any comments on what should be changed/included in the script.
Thanks @Adam-it for the help in preparing it!
Validation failed!
File: docs/docs/sample-scripts/spo/sp_add_ins_and_azure_acs_retirement_report/assets/sample.json
- Invalid 'url' property: The provided URL is not responding correctly!
- Invalid url for thumbnail #1 property: The provided URL is not responding correctly!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @milanholemans, I can see that the sample validation did not pass because of incorrect URLs. TBH I am not sure why they are not correct.
Hi @milanholemans, I can see that the sample validation did not pass because of incorrect URLs. TBH I am not sure why they are not correct.
Good question, it's the first time we see this validator in action. The only thing I can think of is that your script folder contains underscores _ while other sample scripts are using dashes -. Maybe you could try that?
Maybe @PaoloPia can give some more context about the rules that are being checked?
I also think that the referenced issue is referenced unintentionally.
Validation failed!
File: docs/docs/sample-scripts/spo/sp-add-ins-and-azure-acs-retirement-report/assets/sample.json
- Invalid 'url' property: The provided URL is not responding correctly!
- Invalid url for thumbnail #1 property: The provided URL is not responding correctly!
@milanholemans Good point about underscores and dashes; I have changed them to be aligned with other scripts. I can see that the validation result is the same, so let's wait for @PaoloPia's comment.
Hi @mkm17 and @milanholemans, thanks. As the validation message explains, both the url property (https://pnp.github.io/cli-microsoft365/sample-scripts/spo/sp-add-ins-and-azure-acs-retirement-report) and the thumbnail URL (https://raw.githubusercontent.com/pnp/cli-microsoft365/main/docs/docs/sample-scripts/spo/sp-add-ins-and-azure-acs-retirement-report/assets/preview.png) provided in the sample.json file are not valid because they return a 404. Please, update them providing valid URLs and you should be good to go. Thanks for your contribution.
Hi @mkm17 and @milanholemans, thanks. As the validation message explains, both the url property (https://pnp.github.io/cli-microsoft365/sample-scripts/spo/sp-add-ins-and-azure-acs-retirement-report) and the thumbnail URL (https://raw.githubusercontent.com/pnp/cli-microsoft365/main/docs/docs/sample-scripts/spo/sp-add-ins-and-azure-acs-retirement-report/assets/preview.png) provided in the sample.json file are not valid because they return a 404. Please, update them providing valid URLs and you should be good to go. Thanks for your contribution.
Hi @PaoloPia, thanks for the information. I understand that these URLs should work indeed. However, this is a new sample script. This means that the URLs will only work when this PR is merged.
Shouldn't we run this action when building a new release, after we publish our docs?
That's a good point @milanholemans. We're thinking about handling it slightly differently, providing the context of the PR to the backend validation API. In the meantime, if you are sure that the provided URLs will be good once merged, I think you can proceed with the merge. No need to wait. Thanks.
