Louie Perez

Results 7 comments of Louie Perez

I think the issue comes down to this line: https://github.com/thoughtworks/talisman/blob/master/scanner/scanner.go#L45 `git ls-tree -r` will list all files in the repo at the time of that commit, regardless of if the...

Might be able to use `git diff --name-only` to get the file names and then feed that into `git ls-tree -r `

What patterns would we want to use for this feature? It seems like we can submit a negative pattern `!(file)` to the `git ls-tree -r` call but it doesn't allow...

What should the text say?

The confirmation shows up as a banner message, if we want this to only happen after a successful signup should it be part of that banner? Seems a little weird....

I can continue this if no one is working on it. We can use Email Markup to add Inbox highlights: https://developers.google.com/gmail/markup/overview#highlights_in_inbox

Sorry I've been radio silent for a while. I'm happy to continue working or pairing on this. As for whether or not we should pursue this I hear two issues:...