Aaron Dewes
Aaron Dewes
Support for ESM apps landed in v13, full ESM for probot is coming in v14.
This has been implemented by #1719.
For some reason, the tests aren't completing here, which prevents merging this PR. @sugarshin Can you try rebasing this so the tests get triggered again?
Yes, I could trigger them now. I'll merge this later unless someone else objects.
> @AaronDewes thanks! how do I know when a new release with this change will be available? Probot has automated releases, so it's been available since the minute this PR...
This seems to be fixed in v13.
Replaced by #841.
> Conceptually, approved. > > Implementation-wise, however, I think it'd be simpler to just extract the GB/MB specifier and make that an untranslated argument Yeah, that sounds better 👍
> Mac mini with the M1 processor AFAIK apple has a compatibility layer for amd64 apps
Thanks! As I've mentioned before, I have not yet tested this properly yet. I'm planning to run this locally today and make improvements or let you know if I have...