Aaron Dewes

Results 191 comments of Aaron Dewes

@bguillaumat Can you rebase this PR?

:+1: Thanks for having a look and doing these improvements!

> I am a bit confused here. The cache includes the `.ruby-version` file as a cache key, but it does not invalidate the cache. That's why the runs like https://github.com/opf/openproject/actions/runs/8828307074/job/24237045450...

Vielleicht kann ich es auf Deutsch besser erklären als auf Englisch: `restore-keys` ist eine Liste von Prefixen für den `key`. Wenn du also als `key` den Wert `gem-${{ hashFiles('Gemfile.lock', '.ruby-version')...

Awesome! Please let me know if you have something public, I'd love to try it.

@boustrophedon Cann you have a look at this reimplementation? The actual changes are just `15 files changed, 140 insertions(+), 33 deletions(-)`. This now implements both RISC-V and arm64 with a...

> One, seccompiler doesn't support riscv Right, I didn't check for that because it was not used when I made my initial implementation. > Two, I see that you added...

Another thing I could do would be to remove RISC-V and set up a aarch64 VM you can use as actions runner (and then deal with RISC-V later). If you...

> Let me know when you're ready for review but I also noticed that someone has a [PR open in seccompiler for riscv](https://github.com/rust-vmm/seccompiler/pull/72). The code itself is ready for review,...