Aaron Dewes

Results 191 comments of Aaron Dewes

> So you are instantiating a Probot instance for each http request? Yes, Nitro is designed to also work on many serverless platforms, where this has to happen. I'm planning...

I just benchmarked this. It's extremely fast: https://gist.github.com/AaronDewes/3e95469b27a1822326e6230c988b59d4 GistProbot with NitroProbot with Nitro. GitHub Gist: instantly share code, notes, and snippets.

> > instantiating a Probot instance for each http request > > I don't know Nitro, but if its deployed to something like lamda, I think it would make sense...

> Can this be a drop-in replacement for existing `createNodeMiddleware()` function? No, it can't, it uses a complete framework.

@gr2m I got kicked from the org again (I assume by @entitlements :roll_eyes:)

I think the GitHub security team uses this to track org access. Can you check with them? Alternatively, I can also send one of them a message too , but...

Also, being kicked from the org also removed me from all repos again...

Me and @Uzlopak got invited by @entitlements, GitHub's official system for their orgs

> What should we do with current users? How will they upgrade Citadel? They will need to disconnect and re-add their wallet. But only using this API from the Citadel...

> Not everyone is going to update their lnd docker node in their compose file. To not do that, they would need to fork/modify Umbrel, which Umbrel doesn't need to...