Aaron Hill
Aaron Hill
> Can we make it so that any error caused by this hack removal would be explicit about what the user can do to get to working code? What is...
@klensy: That's an interesting idea. I would prefer to remove all special-casing based on crate names, but having a check in cargo does seem less hacky than having rustc alter...
Adding in a cargo warning afterwards could still be beneficial. If users update directly from an old compiler to the latest stable or nightly (containing the cargo change), they'll have...
> It should work by simply changing twitter.com/i/api to api.twitter.com Unfortunately, that didn't work in my local testing - the api.twitter.com endpoints never seem to contain `birdwatch_pivot` > With that...
I've opened https://github.com/zedeus/nitter/pull/1023 which adds support for Community Notes
@asiekierka: You should be able to detect if Sponge is installed by using `LaunchClassloader.getClassBytes` - https://github.com/DimensionalDevelopment/VanillaFix/blob/b6992dc220c65b92f0ad2313ea776271a0b04d45/src/main/java/org/dimdev/vanillafix/ModCompatibilityMixinPlugin.java#L18
This will also be useful when builder Docker images - `cargo build --compile-time-deps` could be used to cache dependencies in a separate layer, without resorting to workaround like https://stackoverflow.com/questions/58473606/cache-rust-dependencies-with-docker-build
I assume that there are no plans to support unions (since it's not clear what it would mean to encode one)?
Was this advanced to Phase 4?
@Herschel @kmeisthax rebased