Tao
Could you explain a bit why "map.remove. The change is wrong." and which way is right? Really thanks. @vlsi
@julianhyde Would you help to review this PR? Thanks a lot.
> The CI failed. Could you resolve it? Sure
TPCH test OOM, I'll take a look. ``` UnknownClass > executionError failure marker FAILURE 0.0sec, UnknownClass > executionError org.junit.platform.commons.JUnitException: TestEngine with ID 'junit-jupiter' failed to execute tests at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:254) at...
 Seems an ustable UT, re-run passed.
Hi The commit message should like this: [CALCITE-4264] Take CPU cost into account in VolcanoCost (your name)
> Would it be possible to have a unit test "showing" the bug? Hi rubenada, sorry for the ut, this part is pretty hard for ut cover, see this: https://github.com/apache/calcite/pull/2056
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
> I have a bad feeling about this change. It adds a lot of new code and does not leverage existing code (e.g. reasoning based on predicates). It is going...
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
Recently I'm really busy, sorry for the slow progress, will restart soon.
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
@rubenada Hi, could you help review it after updating~