Tao
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
@rubenada I've updated my PR, could you take a look, thanks a lot?
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
> @Aaaaaaron thanks, great work. > I have left some minor final details, otherwise LGTM @rubenada All revised, thanks for your careful review, really appreciate it!
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
@vlsi Thanks for your nice review, I update my PR, here a separate commit for your to review again, thanks again! https://github.com/apache/calcite/pull/2253/commits/b22496b3536a4c789a676688d94b2c98be011604 @rubenada May you also review again? Thanks!
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
Hi @rubenada, could we merge this PR if there are no more comments?
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
> Can we please set a hard limit on the maximum number of back-and-forth, and close/reject PRs that exceed it? > > I see the PR does not meet code/performance...
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
> @Aaaaaaron, We are showing respect. But we are volunteers, and reviewing changes takes time away from other work we could be doing. This conversation has 84 entries. Every one...
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
> @Aaaaaaron, We are showing respect. But we are volunteers, and reviewing changes takes time away from other work we could be doing. This conversation has 84 entries. Every one...
[CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)
> @Aaaaaaron , > > 1. I have no time here. No details, sorry. > 2. The comments (e.g. "code/performance", "checkDuplicateSubset") are helpful for other reviewers and committers so they...
+1
Hi @sadikovi , I submit an initial commit and there are some remaining work to be done. And any review comments are welcome. Thanks a lot! - [x] basic logic...