AZero13

Optimize bit handling in archive_compressor_xz_init_stream

4

Add intrin.h for _BitScanReverse. This makes the operations being done much clearer and also faster as well.

Some operations, like assigning to 0, or breaking after a non-returning function, are redundant and can be removed.

The return value is never used, so let's change it to void.

Avoid branch by adding xfer_align to cf->buff

4

We can avoid a branch by not comparing with 0.

git: use logical-not operator to toggle between 0 and 1

33

If it is known that an int is either 1 or 0, doing an exclusive or to switch instead of a modulus makes more sense and is more efficient. cc:...

Prefer fgetc over fgets where possible

6

fputc is meant for single characters, fputs is for strings. We are better off inserting sole \n characters as characters, not whole strings.

mingw: prefer RtlGetVersion over GetVersion

15

GetVersion has its behavior changed in Windows 8 and above anyway, so this is the right way to do it now. The previous way returns the wrong value in Windows...

mingw: check that the file attributes are valid before modifying them

8

OK

git: replace strbuf_addstr with strbuf_addch for all strings of length 2

7

cc: Eric Sunshine

die: fix inconsistencies with header

6

The headers for the die and usage functions have different parameter names or are missing the "NORETURN" attribute