AZero13

Fix clang-tidy string warnings

32

These changes greatly simplify the code and makes the intent more clear.

Fix a handful of clang-tidy warnings

7

This fixes a couple of warnings raised by clang-tidy. Addendum: When I wrote this, I was under the impression that clang-tidy warnings were compiler warnings. I now know that this...

Use the correct format specifiers

1

opt_len, static_len, bits_sent, etc. are all unsigned longs, not signed longs. For this reason, the Trace_ev strings should be changed to reflect that.

It makes sense for these values that are expected to be unsigned to be treated as such, especially on 64 bit platforms where we can avoid the cost of truncation...

Introduce PTR_SUB

1

This is more intuitive than adding a negative number.

recv_ida_entries still needs to be called regardless, so we cannot take that out. Let's just quiet the compiler instead.

Prefer size_t over int where possible

16

This avoids needless truncation, which takes up multiple more instructions on some architectures, especially older ones.

Use compiler intrinsics to find the nearest power of 2 as quickly as possible. In addition, handle the 0 case, so that the program does not become stuck in an...

Make i, n, index, and max_stmts unsigned integers

2

This fixes compiler warnings regarding signedness and avoids casting. maxval should be an unsigned integer because slength, the result of which is added to this number, returns an unsigned value....