Mariano Uvalle

Results 11 comments of Mariano Uvalle

Could you provide more details? I'd like to take a crack at this. I'm assuming it's the `problems` variable which is called the same as the user defined types.

Hi @cohix can I take on this? I was thinking about refactoring the whole https://github.com/suborbital/reactr/blob/main/rcap/http_rulefilter_test.go file first and then see if there's any other tests in the repo that can...

Just submitted a PR, I'd appreciate some reviews :)

Do you have more insight on this? I'd like to work on it.

For event model: https://github.com/AYM1607/do_more/commit/2f12601c1f05a25c05315490da276532d6bcba1e

overriding the operators seemed like a good idea. However, some models have attributes of non primitive types, this causes the equality check to fail even with the overrode operators. Would...

Thanks for the PR! I hadn't seen this before but I'll go ahead and update the parts list to include the sockets :)

Tests for the operations regarding events and tasks are already in place.

https://github.com/AYM1607/do_more/commit/4aadfbde8c179c361b01b8c8ecfa2f61ef05217a fixes this issue