e2core icon indicating copy to clipboard operation
e2core copied to clipboard

problems variable name shadows / conflicts with struct name

Open javorszky opened this issue 3 years ago • 3 comments

It's in the directive validator: https://github.com/suborbital/atmo/blob/main/directive/directive_validator.go#L16

javorszky avatar Feb 23 '22 11:02 javorszky

Could you provide more details? I'd like to take a crack at this. I'm assuming it's the problems variable which is called the same as the user defined types.

AYM1607 avatar May 17 '22 02:05 AYM1607

Hi! Thanks for the offer 🙂

Yes, you're right, the variable and the type should not be named the same.

javorszky avatar May 17 '22 08:05 javorszky

@javorszky Can you review it?

bishal7679 avatar Jul 07 '22 14:07 bishal7679