Castro icon indicating copy to clipboard operation
Castro copied to clipboard

output where and why the timestep limit is set

Open zingale opened this issue 6 years ago • 4 comments

We should have an option to print out where in the domain is the most restrictive timestep and what limiter is the cause (hydro, diffusion, reaction, ...)

zingale avatar May 08 '18 12:05 zingale

We already print out which limiter is controlling the timestep, so this is half done already :-)

maxpkatz avatar May 08 '18 14:05 maxpkatz

it doesn't seem that we separate the diffusion timestep from the hydro timestep. It would be nice to know which of these is at fault.

zingale avatar May 08 '18 14:05 zingale

That is true.

I'll note that since we already perform two AllReduce calls to get both the hydro and reactions limited timesteps, and doing one for diffusion would add a third, we could combine these into a single ReduceRealMin and just do the minimum over all three at once (Weiqun added at some point the ability to hand initializer lists to the ParallelDescriptor routines).

maxpkatz avatar May 08 '18 14:05 maxpkatz

Seems like MPI_MINLOC (https://www.mpi-forum.org/docs/mpi-1.1/mpi-11-html/node79.html) could be useful for the location information.

maxpkatz avatar May 08 '18 14:05 maxpkatz