Anders Jenbo
Anders Jenbo
Nice work. I'm seeing a lot of good changes in this PR. I do have a couple of notes regarding the changes. - While `LiftGargoylesOrIgnoreMages()` does maybe better describe what...
@DakkJaniels you can just ping me in the actual PR :D I'll have a look at it tomorrow.
> I wish some more structure is possible. Like modules, folders. But I have no idea how to decomposite such files. The answer: Slowly. You can see it already happening...
Let me know if you need any help with rebasing :)
> I wish I could do just iterated rebase and squash most of this things here in this PR, but I don't know if it is possible to do such...
> I was thinking it is possible to review it while draft, but seems it is not possible It is, but usually you won't get as thorough a review as...
@stefanmielke both StormLib, snprintf, and vsnprintf have been removed as dependencies so this should probably workout much better if rebased :)
Make sure it's not a debug build
> Sample Rate 48000, Resampler Speex and Resampling Quality 10 This is probably the issue, try quality 3 or sample rate 22050
Also a surprising number of times removing some dead code removes a special case that makes it possible to clean up other parts of the code.