Anders Jenbo
Anders Jenbo
It looks to me like that situation might have already been possible in the original
good point, they probably used a different compiler with it's own includes so int8 could be signed there, just like it is for modern VC.
For now, we have added `-fsigned-char`, it may not be supported by all compilers and as mentioned in the documentation this isn't the ideal solution: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html MSVC appears to work...
`Latest master` which one was this for you at time of writing?
It would be nice if we can set it to 1 during loopback (it does know how many max players is for any connection type)
Yeah, was just thinking out loud :)
I'm going over the various parts of the code that leads to all the casting and cleaning it up so that it can be avoided. I'll rebase as the the...
Since the first one was merged so quickly I only had time to make a small follow up :) https://github.com/diasurgical/devilutionX/pull/4802 (I have a larger change set that cleans up about...
Here is another nice chunk of cleanups in player comparisons https://github.com/diasurgical/devilutionX/pull/4803 :) Just 45 lines to go.
One more ready: https://github.com/diasurgical/devilutionX/pull/4805 Also I think I have everything cleaned up now and just need to split it in to individual PRs, so hopefully I can have it all...