Results 1104 comments of Anders Jenbo

looks really cool. I don't think this PR is ready to merge in it's current state as the map relies on things that are not in DevilutionX

We have Lua now thought...

You can pull in miniaudio via git submodules or downloading them manually and specifying DOWNLOAD_DEPENDENCIES=OFF for cmake. 64bit is also supported so if you want you can have it run...

> I added it to the System Environment Variables (eww windows user) and nothing has changed. You have to restart for it to affect sub proesses

This does not appear to be an issue in portable, please re open and provide additional info if you still see it with your mod.

I know that it can be installed on 8.4. i did mention that in my description. But even from PECL it is a bit tricky to install, for example it...

> Bladestan considers each view and component instantiation individually, so does not know that the same parameter takes different values elsewhere Correct. Your workaround is the current recommended solution, but...

```php /** @var bool */ $showArticles = true; view('template', compact('showArticles')); ``` Other options is using a DTO (that's what the class for a component is as well), or returning it...

Adding `/** @var bool $showArticles */` to your template may also work, but this runs the risk of obscuring when a variable was not provided or other type issues.

> Also, was this workaround documented anywhere? No, it's just something I know from using Bladestan at work... it's one reason I don't think Bladestan is ready for a 1.0...