sui icon indicating copy to clipboard operation
sui copied to clipboard

Explorer: Handle partial failure in batch requests gracefully

Open 666lcz opened this issue 3 years ago • 2 comments

context: https://mysten-labs.slack.com/archives/C03G361KUR2/p1655433492475619

666lcz avatar Jun 21 '22 15:06 666lcz

@longbowlu to create an issue to track this on the backend

666lcz avatar Jun 21 '22 15:06 666lcz

It turns out that the existing code already tolerates partial failure. I verified this by inserting an invalid transaction https://github.com/MystenLabs/sui/blob/c7e27a3f6daf9fcde05fcf88b3511a70eaf08d97/explorer/client/src/utils/api/DefaultRpcClient.ts#L33 and the transaction table is rendered correctly. It seems that the batch request will fail entirely only if one of the requests panicks.

666lcz avatar Jun 28 '22 14:06 666lcz