Donal Linehan

Results 22 comments of Donal Linehan

What's being passed to the two callbacks is different so they're not compatible- `afterAdd` returns the item added to the array whereas `afterRender` returns the rendered dom elements.

Just to note, the return was removed recently in this pr https://github.com/jm-david/emoji-mart-vue/pull/42

> which should also get ride of coffeescript (in favor of typescript?) Either that or just plain old js with jsdoc annotations 👌

I would love to be able to implement this but haven't been able to find any mention of how to accomplish it with registry keys. If anyone has an ideas...

This isn't a priority for us but we'll happily accept a pr for this change. Thanks for the suggestion!

@Oxalin Thanks for your offer of help! I've added you as a contributor to the repo. Shout if you need a review 👌

Is a nice idea- though wouldn't using SSL provide the same security without the need to generate any app specific keys etc?

@sashahilton00 @majodev Popcorntime seem to have implemented dsa signing of packages in their updater. Copy, paste, pr :smile: https://git.popcorntime.io/stash/projects/PT/repos/popcorn-app/browse/src/app/lib/updater/index.js#137

This might be the same/related https://github.com/react-native-maps/react-native-maps/issues/5569

pr here https://github.com/react-native-maps/react-native-maps/pull/5573/files