node-auto-launch
node-auto-launch copied to clipboard
Teamwork
Add option to pass additional arguments
Target platforms this affects (Linux, Mac, Mac app store, and or Windows):
For now, I have only implemented this on Linux. I have to take a better look at how the Windows and Mac functions are structured. Of course, feedback from the Teamwork team is welcome.
What problem does this solve?
Addresses #46; Sometimes it is nice to pass additional command-line arguments to an app, for instance, Wire Desktop includes a flag --startup to start minimized. Now I can add extraArgs: "--startup", to my launcher so that the wire.desktop file includes the flag.
Could it break any existing functionality for users?
At least on Linux, I am confident that this shouldn't break any existing functionality.
It'd be great if someone with Mac/Windows experience could recommend how to make this work on those platforms. I can tinker, but I can't test on Mac. I can probably test on Windows, but don't have a testing environment set up, as I'm a full-time Linux user.
As mentioned in previous comments, I don't have access to a Mac / Windows machine to test this, so Mac and Windows are currently untested.
Please see that we're looking for contributors / maintainers: #64.
I'm happy to give access to people who are willing to help improve things, merge pull-requests, close issues, etc.
Not a big change, but I don't know if we should add parameters one after the other (extraArgs, onlyMe, etc.) or if this should be regrouped under and array of options.
Not that this PR is bad, but I would suggest to include this feature change in a broader and more flexible way. We should be able to push whatever argument, which should include "mac" and "isHiddenOnLaunch".
Let's push this change to a major version bump, which should also get ride of coffeescript (in favor of typescript?)
which should also get ride of coffeescript (in favor of typescript?)
Either that or just plain old js with jsdoc annotations 👌
Not that this PR is bad, but I would suggest to include this feature change in a broader and more flexible way.
As the person that hacked this PR together 7 years ago with no prior Coffeescript experience (and no experience since, either!), I will not take any offense to this PR being closed and done in a better / more flexible way.
What I would see is an @options object where we could define: {appName, appPath, options} where would contain at least the following optional object options: { boolean isHiddenOnLaunch, object mac { boolean useLaunchAgent }, array args }
One PR will be merged under the "decaffeinate" branch which contains a new feature to add more arguments, I'll add a few more testcases to be sure additional arguments are properly added under all OSes.