emoji-mart-vue icon indicating copy to clipboard operation
emoji-mart-vue copied to clipboard

Published 20 hours ago • verified publisher icon jm-david

return data from uncompress method to fix issue #48

Open ikoolik opened this issue 6 years ago • 3 comments

Issue https://github.com/jm-david/emoji-mart-vue/issues/48

In src/utils/emoji-index/nimble-emoji-index.js line 7, we assign the return value of the uncompress(data) call to the data variable. But the named function has no return value.

Because of this, the headless search is not functional. This quick fix should fix the issue.

ikoolik avatar Feb 06 '19 15:02 ikoolik

Just to note, the return was removed recently in this pr https://github.com/jm-david/emoji-mart-vue/pull/42

4ver avatar Feb 06 '19 16:02 4ver

I just found another PR #45 that also addresses the same issue but from a different angle (sorry, should've checked before creating my own)

Merging either #45 or #49 should fix the bug.

ikoolik avatar Feb 06 '19 16:02 ikoolik

Imo, PR #45 would be better approach than this as the data object is already mutated thus returning it will make no sense and will just add extra overhead.

uniibu avatar Mar 02 '19 12:03 uniibu