James Garbutt

Results 341 comments of James Garbutt

I'll try get the branch caught up and see if everything now works fine with import attributes A designer friend of mine made the image. I'll ask her nicely and...

we're in a bit of a pickle with a stackblitz example 😬 it seems we can't use `with` until CSS modules are a thing. esbuild won't implement it, so it'll...

My preference would be to go even further and move the project into the lit org so I'm not keeping it aligned to lit solo. However we did have some...

ill see if i can raise it in the weekly lit eng catch up meanwhile its also roughly tracked here as a larger issue: https://github.com/lit/lit/discussions/3705

this would mean chai extensions (properties, methods, etc) get overwritten/added each time right? do we know what our suggestion would be to plugin authors for ensuring they don't accidentally duplicate...

in chai 4 it would've only called it once afaik (thats what `used` was for) i may be talking nonsense but maybe someone does something like this: ```ts chai.overwriteProperty('equal', function...

basically im not sure if `overwriteProperty` multiple times results in the original being `super` or the last overwritten one given the example before: ```ts chai.overwriteProperty('equal', function (_super) { if (something)...

i just tried it and it seems to call it once in both 5 and 4 its because its a method (`equal`), not a property: ```ts import * as chai...

basically this is what i'd tell authors to do (`overwritten` flag): ```ts import * as chai from 'chai'; let overwritten = false; function somePlugin(base) { if (!overwritten) { base.util.overwriteMethod(base.Assertion.prototype, "equal",...

it may also be worth just building this functionality into chai itself, as some variant of `includes` much of the logic in chai-subset exists in chai already, just not for...