James Garbutt
James Garbutt
maybe a selector should instead match the interface atom() returns? like `{key, getState}` so it is interacted with just the same way. would make it more consistent that way imo
fixed two more: - dynamic import of chokidar in tests needs to be the exact path, rather than a directory - race condition in the `close` test if you're curious,...
we're down to 3 failing tests now. this change: - implement `ignoredPaths` again using relative path computation to figure out if it is a child or not - rework anymatch...
one thing i just updated: in linux, the inode of a watched file can change when the file is replaced. it seems that same behaviour happens in macOS too, but...
tbh my preference would actually be one of these: - upgrade mocha/chai - latest chai is esm only - latest mocha supports esm out of the box - use node's...
FYI it finally passes tests in ubuntu with node 20.x all other targets fail right now - Windows (WSL), fails miserably. not too sure whats going on there - MacOS,...
@paulmillr maybe im missing something or maybe i've had a mini-revelation: can we just not use fsevents anymore? the node docs: > On macOS, this uses kqueue(2) for files and...
👍 makes sense to me, i'll see where i get to once i have ci passing at least
@paulmillr this should pass CI now at least i had to rework the "thirtythree files" test to wait for each file individually to call the spy.. does that still test...
sure, have updated CI. will see if 21 passes now 👀 thats what i've been using locally mostly so it should be fine as for dropping fsevents btw - i've...