James Garbutt

hey justin 👋 the vue stuff is broken because the svelte rule is matched by the vue plugin, which breaks the loop and never reaches the vue rule. see here:...

also the test fails for some unrelated error right now: > Error: Conflict: Multiple chunks emit assets to the same filename bundle.js (chunks main and runtime) Which also reveals that...

i can try pick this up if you don't have time @justinfagnani @sokra webpack5 has its own types now i see, but it doesn't export quite a few of the...

No worries, I'll have a go at finishing it off. Also have opened a PR at definitelytyped to update the mini-css plugin so you don't have to cast it as...

do you happen to know which stylelint rule does that for you? we do have some stylelint tests already so i can probably reproduce it fairly easily once i know...

you're probably right that we should just mark CEs as used when passed through the customElement decorator since it is lit-specific knowledge/side-effects, it seems to make sense we tackle it...

i had a think about this, its a bit of an awkward one for us to solve basically, multiple rules work against lit classes conditionally (i.e. `if (isLitClass(cls)) { doStuff();...

that makes sense in their case as they have a rule for detecting those types we don't really have a rule whose purpose is to detect registered custom elements, so...

the only reason the jsdoc plugin has a sensible place for it is because they have a rule specifically for detecting type references in JSDoc comments. they then mark them...

Ah interesting, you can see the react plugin went exactly that route: a no-op rule that exists solely to mark some vars as used I'll have a think about it...