Denis Rouzaud comments

Results 136 comments of


                                            Denis Rouzaud

Feature: Show affected subscribers when adding a leak on a pipe

Sadly, I'll miss the next meeting because we're waiting for a child just a few days after the HF... We can start here or by mail if you like.

Feature: Show affected subscribers when adding a leak on a pipe

Thanks. I don't think so. The norm is for us to never place a valve at the intersection of pipes but always on a pipe. So the valves close or...

Feature: Show affected subscribers when adding a leak on a pipe

Well, we don't split pipes, and we have a recommendation not to do so. How is it in epanet? So, there is no node to apply. I think that splitting...

fix adding a circular string geometry on a compound curve layer

I was looking at this. There is a bit of redudancy with `QgsGeometry::coerceToType`, I'm looking if we can move this,

fix adding a circular string geometry on a compound curve layer

So, I'm a bit skeptical on the approach here. Basically, `QgsVectorDataProvider::convertToProviderType` is doing the same job than `QgsGeometry::coerceToType` but not exactly. `convertToProviderType` is used in `QgsVectorLayerEditBuffer::commitChanges` prior to do any...

fix adding a circular string geometry on a compound curve layer

I've made a new PR for this https://github.com/qgis/QGIS/pull/53484

separate job for QA tests

coverage is missing, should it simply be added to `requirements-unit-test.txt`, or should it come from `openwisp-utils[qa]`?

separate job for QA tests

This sound great!

Allow geometry-less models

Thank for the feedback! I added some tests. May I ask why running the test workflow requires an approval? It would ease the process to have a quicker feedback. Cheers.

Allow geometry-less models

I made something wrong with my last force push, trying again.