django-rest-framework-gis icon indicating copy to clipboard operation
django-rest-framework-gis copied to clipboard

Published 20 hours ago • verified publisher icon openwisp

Allow geometry-less models

Open 3nids opened this issue 1 year ago • 16 comments

A null geometry is returned in such case

Fixes #282

3nids avatar Sep 27 '23 21:09 3nids

Thank for the feedback! I added some tests. May I ask why running the test workflow requires an approval? It would ease the process to have a quicker feedback. Cheers.

3nids avatar Sep 28 '23 10:09 3nids

api.py", line 150, in pass_env_post_process raise Fail(msg) tox.tox_env.errors.Fail: pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'TRAVIS TRAVIS_*' Error: Process completed with exit code 1.

auvipy avatar Oct 08 '23 07:10 auvipy

I made something wrong with my last force push, trying again.

3nids avatar Oct 10 '23 05:10 3nids

hope this will be green this time!

auvipy avatar Oct 10 '23 06:10 auvipy

Looks like I didn't run makemigrations. hopefully I'll be back...

3nids avatar Oct 10 '23 06:10 3nids

I don't understand what's the problem, may I ask your help @auvipy ?

3nids avatar Oct 10 '23 14:10 3nids

ping @auvipy

3nids avatar Oct 17 '23 09:10 3nids

This time, I don't think I'm responsible of the failure... image

3nids avatar Oct 18 '23 13:10 3nids

@auvipy could you trigger the CI again please?

3nids avatar Oct 28 '23 08:10 3nids

Done

auvipy avatar Oct 28 '23 09:10 auvipy

@auvipy thanks...one more try.

3nids avatar Oct 28 '23 09:10 3nids

I haven't touched anything in tox.ini, quite strange. But I was wondering why there was some reference to TRAVIS variables in it? remains from the past? Maybe this needs to be dropped?

3nids avatar Oct 30 '23 07:10 3nids

done, thanks!

3nids avatar Oct 30 '23 21:10 3nids

gentle ping to trigger the CI....

3nids avatar Nov 01 '23 07:11 3nids

would it be possible to retrigger the tests?

3nids avatar Feb 15 '24 10:02 3nids

Triggered @3nids

nemesifier avatar Feb 15 '24 16:02 nemesifier

@nemesifier thanks to the help from @suricactus this should be good now. That'd be great to re trigger the tests! Cheers!

3nids avatar Mar 04 '24 13:03 3nids

@3nids this makes all tests to pass locally. Forgot to commit last time: https://github.com/3nids/django-rest-framework-gis/pull/2

suricactus avatar Mar 04 '24 22:03 suricactus

@nemesifier thanks again, should be good this time 🤞

3nids avatar Mar 05 '24 05:03 3nids

ping @nemesifier

3nids avatar Mar 15 '24 08:03 3nids

@nemesifier @suricactus I just dropped the 2 is not None and pushed. Could you retrigger the tests? cheers!

3nids avatar Mar 19 '24 07:03 3nids

@nemesifier gentle ping :)

3nids avatar Mar 21 '24 05:03 3nids