Fred Silberberg

Results 412 comments of Fred Silberberg

I'm locking this issue as all of our issues should be locked in the new repo organization; apologies that it wasn't locked already. Feel free to start a discussion to...

> If we ``, does it just work, ignoring all the new script-focused # directives? Yes, *but The but is important though: `#:package [email protected]` is going to produce an error...

> If the script file uses top-level statements, and our benchmark project has a `UniqueProgramName.Main` that we set as the entry point using `BenchmarkDotNet.Autogenerated.UniqueProgramName`, do the top-level statements get ignored?...

Alternatively, we could consider making the `#:` error a warning instead? I'd like to hear @jaredpar and @jjonescz's thoughts on that as well.

Yeah, that is fair; I usually just need BDN itself, but if there's some other 3rd party dependency I'm benchmarking it would fail. Likely the cleanest option would be to...

> I think it's relevant because today they are in 2 separate projects, while compile include would make them 1 project, and I'm not 100% sure if the compiler is...

I think it would have to be. From the [TLS](https://github.com/dotnet/csharplang/blob/main/proposals/csharp-9.0/top-level-statements.md#semantics) spec: > The [TLS] method is designated as the entry point of the program. Explicitly declared methods that by convention...

@dasMulli see https://github.com/dotnet/roslyn/issues/34678

@hamarb123 please keep discussion in the discussion thread.

Go for it, though I will be out until late August.