Fred Silberberg
Fred Silberberg
A 3rd option, one I think I'm most in favor of: * Delete `RazorSourceDocument`, and use `SourceText` directly.
> Having some sort of higher-level document class is valuable for hanging additional data on. SourceText is just meant to represent a text. A `RazorSourceDocument` is only `SourceText` + `FilePath`....
> That is basically down to [this block of code](https://github.com/dotnet/roslyn-analyzers/blob/main/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DetectPreviewFeatureAnalyzer.cs#L812-L839). That code on it's own (no inlining) is very hard to see a NRE on. Agreed. Looking at that block,...
I talked with @gafter briefly about this. This is intended behavior. An oblivious value is being assigned to an explicitly non-null variable. Therefore, we presume that the user knows what...
Yes, the compiler tries to lose oblivious as soon as it's able to.
@allisonchou I don't know what you're expecting us to do differently here. As I've said on similar issues in nested contexts, the only way that we can change this is...
> Or are you just clarifying that it will take some time (longer than a sprint)? I'm saying this one. It's a significant chunk of work.
I don't expect this to be going away any time soon, no.
This should be handled with the lexer changes.
No, this is not by design. We could adjust this behavior as an optimization.