Luc Grosheintz

Automatic formatting fixup breaks CI.

1

When a PR isn't formatted correct, a bot will create a commit that fixes the issue. However, after the bot pushes the commit to the PR branch, not all required...

Wrong voltage in direct function calls for non-threadsafe MOD files.

3

To expose the bug we need a non-threadsafe MOD files, e.g., ``` NEURON { SUFFIX non_threadsafe_voltage } ASSIGNED { v } FUNCTION get_v() { get_v = v } VERBATIM //...

Make NOCMODL output formattable.

4

For non-threadsafe MOD files, this restores the ability to use `clang-format` to format the files.

During review of #3018, @mgeplf raised the question if the ref count needs to be preserved for `Py2NRNString`, for example this line here: https://github.com/neuronsimulator/nrn/blob/ddf1beef62f5b60d17ca2cada96d3be3bc7c3d4c/src/nrnpython/nrnpy_nrn.cpp#L1982 and likely several other occurrences (in...

Thanks to @mgeplf for noticing that the ref count for `obj` isn't sharp: https://github.com/neuronsimulator/nrn/blob/ddf1beef62f5b60d17ca2cada96d3be3bc7c3d4c/src/nrnpython/nrnpy_nrn.cpp#L198 See the following comment on #3018: https://github.com/neuronsimulator/nrn/pull/3018#discussion_r1696540642 The task is to carefully review the ref counting...

Move Developer Build documentation.

2

I'd like to propose moving the developer build documentation from Building to the Developer Documentation. Mostly this is because the Developer Build (sensibly) contains Perf instructions. Finding the perf instruction...

The entrypoints into the MOD file from NEURON typically require setting up some variable, e.g. `_lmr`, `inst`, `node_data`, `_thread_vars`, etc. The code has roughly two favours: * From fully initialized...