nrn icon indicating copy to clipboard operation
nrn copied to clipboard

Automatic formatting fixup breaks CI.

Open 1uc opened this issue 1 year ago • 1 comments

When a PR isn't formatted correct, a bot will create a commit that fixes the issue. However, after the bot pushes the commit to the PR branch, not all required CI is run again. Typically,

  • Code coverage,
  • Documentation,
  • Final CI (i.e. all the GHA checks)

are left in an orange, "expected" state. I suggest we either remove the fixup bot, make the fixup bot opt-in like ModelDB CI, or fix the CI to ensure it runs again after pushing the fixup commit.

1uc avatar Aug 29 '24 05:08 1uc

(not that my input counts as much, but I prefer remove the fixup bot, or make it opt in)

mgeplf avatar Aug 29 '24 07:08 mgeplf