Luc Grosheintz

Rework how Newton code is included.

1

We now unconditionally add 450 lines of boiler plate related to Newton to every generated file. It makes files needlessly hard to read. We should only include the code when...

Fix `_nrn_layout_reg`.

5

CI_BRANCHES:NEURON_BRANCH=1uc/remove-cnrn-mech-layout

Review CI for `pip install . && nmodl`.

2

Locally I'm getting an error for the following: ``` $ pip install . $ nmodl /nmodl/venv-dyn/bin/nmodl: error while loading shared libraries: unexpected PLT reloc type 0x00 ```

It's unclear why it's needed, it's poorly named and only present in the codegen for NEURON. Likely it's not useful.

Review `factorial`.

1

In `nocmodl` the string `factorial` is reserved for the function factorial and will refuse to compile. In NMODL, it seems to generate a user-specified and it doesn't not error out....

I'm getting 33% covered, on a PR I thought I would be doing much better (#1285). It might be that the usecases aren't run during coverage. We should double check.

There two copies of `llgramarea`: https://github.com/search?q=repo%3Aneuronsimulator%2Fnrn%20llgramarea&type=code This causes issues with Cython, because it's dlsym'ed, but also available via Cython. The latest version of Cython uses name manging when generting C++...

Review supposedly dead code in RxD.

1

The following lines are suspected to be dead code: https://github.com/neuronsimulator/nrn/blob/7b9e1be83f16e36ec5e60d3da0cda1731938ae17/share/lib/python/neuron/rxd/rxd.py#L622-L636 This ticket extracts a task from review comments: https://github.com/neuronsimulator/nrn/pull/3040/files/7b9e1be83f16e36ec5e60d3da0cda1731938ae17#r1729011132 CC: @ramcdougal, @ceciliaromaro