Minh Nguyễn

Results 1323 comments of Minh Nguyễn

> OSRM uses an Earth radius of 6 372 797.560 856 when calculating distances There’s some discussion about whether OSRM’s value is correct: Project-OSRM/osrm-backend#5051.

This is about the [Optimized Trips API](https://www.mapbox.com/api-documentation/#optimized-trips), which is currently available as a preview. There’s quite a lot of overlap between that API and Directions API v5, which is why...

This is one half of #392: that issue also tracks eliminating the DirectionsResult abstract base class, which is also desirable but not as urgent.

> Line 410, 411, 413 shows 3 forced unwrapped objects that could be part of the problem Force-unwrapping here essentially asserts that the URL is a well-formed URL. That most...

> the existing `NavigationMatchOptions` set `coordinateAccuracy` to -1 to ignore radiuses in the request, I don't know why I think the expectation is that NavigationMatchOptions’ coordinates would come directly from...

> So the `coordinateAccuracy` should be unset further up the call chain, in `NavigationMatchOptions(locations:profileIdentifier:)` or `Waypoint(location:)`, or preferably in whatever calls `NavigationMatchOptions(locations:profileIdentifier:)`. mapbox/mapbox-navigation-ios#1907

There’s a simpler workaround in https://github.com/mapbox/mapbox-navigation-ios/issues/1907#issuecomment-448808887, by the way.

The navigation SDK’s [RouteProgress](https://docs.mapbox.com/ios/navigation/api/2.6.0/Classes/RouteProgress.html#/Leg%20Statistics) class has some conveniences for this kind of thing, but MapboxDirections tends to stick to functionality that’s provided by the Directions API itself. > Is there...

> For the dependency class, I created a new class by subclassing, and on completion block I want to return a mock object for "Route" What does the subclass look...

Does this issue still persist? We’ve since rewritten the library to use pure Swift instead of bridging to Objective-C. I realize your test is written in Swift, but I wonder...