Aurelia Molzer

Results 457 comments of Aurelia Molzer

There's a really intriguing color difference between the two images. ffmpeg has inserted some sort of dithering in some of the solid color blocks. Other than that defect, the big...

That's a pretty large iTXT chunk of 1314946 bytes in there. The problem: the decoder is allocating a vector with chunk contents and it's not using the limit configured for...

Prior art: `libpng 1.6` ```c typedef struct png_unknown_chunk_t { png_byte name[5]; /* Textual chunk name with '\0' terminator */ png_byte *data; /* Data, should not be modified on read! */...

Unknown chunks are currently always skipped over. This is technically not quite right but at least it won't fail to decode images.

I very much like the idea of a builder-style struct for the decoder that would allow configuring these options, and also to turning that validation _off_ by default. At most...

> The tRNS chunk shall not contain more alpha values than there are palette entries, but a tRNS chunk may contain fewer values than there are palette entries. In this...

That actually all seems to be handled as best as possible, as far as I can tell. tRNS consists of 174 nul-bytes. ``` (ChunkType { type: tRNS, critical: false, private:...

Method types and bounds on various methods of the [`filter mod`](http://docs.piston.rs/imageproc/imageproc/filter/index.html) are not consistent, e.g. --- `median_filter` restricts to the u8 subpixel type exactly: > `P: Pixel + 'static` It...

I see how `median_filter` doesn't generalize with the same runtime. Nevertheless, shouldn't `O(radius*ln(radius))` per pixel be possible through maintaining a sorted list/other structure of the values? The proposition of `mean_filter`...

That seems partially right. The 'at most one write' is not a hard requirement and it's not entirely clear either. See in particular this issue: https://github.com/rust-lang/rust/issues/56889. However, I very much...