Aurelia Molzer

Results 457 comments of Aurelia Molzer

Sounds good to split it up. Consolidating chunk is a very good and orthogonal change compared to the prior explicit line/tile differentiation.

> If there is another ifd and it's outside the 1024 bytes i should be able to call next_image(new_bytes) and get an error if we can't decode the next ifd...

Note that at least one image — `caspian.tif` — contains a private tag (42212/0xa480, see https://www.awaresystems.be/imaging/tiff/tifftags/private.html). See #47 for a discussion on handling these.

> Regarding your example, rust unsafe vs safe doesn't cover logical behavior. If I change the behavior as demonstrated in your example its still perfectly safe with respect to Rust's...

~~Outputting trailing zeroes is fully within the specifications of `printf` as far as I am aware, basically guaranteeing roundtrip is the only necessity.~~ [As far as I am concerned this...

If you can sponsor encode/decode integration of JPEG XL (https://docs.rs/jpegxl-rs) that'd be great. We can surely give guidance in reviews and early design work if portions of bindings require it,...

Gracefully returning an error would be a better way towards working to a real solution. Wrong results easily become (improperly) relied upon before they are fixed. The library explicitly has...

@djc The evening of saturday, ping me if not. There's another release outstanding too

> I'm not sure how I would go to resolve the 2 pointed out issues in the code. Process wise, you make another commit to your branch wherein the issues...

Ah, it works as a zip file: [crash.zip](https://github.com/baldurk/renderdoc/files/9619845/crash.zip)