Aurelia Molzer

Results 457 comments of Aurelia Molzer

> What would be wrong with providing access to the png::Info (eg. PngEncoder::new_with_info, if the tests I plan to do after I sleep show that adding text chunks doesn't freeze...

> Requiring init (and by extension set_limits) to be called before reading the dimensions makes it basically the same as just having a with_limits constructor. It's a dyn-compatible way that...

@fintelia This now includes the other changes including to `ImageReader` as a draft of what I meant in https://github.com/image-rs/image/issues/2679#issuecomment-3590938582. In short: - The file guessing routines and the _construction_ of...

> 1. init. This is just two-phase initialization and opens so many questions. That was one of the open questions, the argument you're presenting makes it clear it should return...

> But now consider the same example of JPEG decoding line by line under the current API. What should Decoder::viewbox return? A viewbox relative to the surrounding 8x8 aligned grid....

Resolving the naming question as `peek_layout`, hopefully satisfactory for now.

@fintelia I understand this is too big for a code-depth review but I'd be interested in the directional input. Is the merging of 'animations' and simple images as well as...