Simon Dowdles comments

Results 52 comments of


                                            Simon Dowdles

Update Analytics to use new gtag infrastructure

Note to AC reviewer, this has largely been kept as is from the Consent Mode epic, having reviewed the POC at https://github.com/google/site-kit-wp/commit/82d9f946211c37bb54a40f189490215ece69c86b this should be a "lift and shift" effort.

Standardise "Incomplete Setup" list in Settings for Ads and AdSense modules when AdBlocker is detected

AC ✅

Create `conversion-tracking.js` Datastore

AC LGTM here, but noting that during IB we may want to consider a selector to check if conversion tracking is enable via a selector such as `isConversionTrackingEnabled()` or similar.

Create Proxy Event Tracking Function to Add Site Kit as Source for All ICE Events

@tofumatt as per out comms offline, I think it makes sense to: - Have this function be contained within it's own script that we will enqueue - Register it as...

Create Proxy Event Tracking Function to Add Site Kit as Source for All ICE Events

> Just one question really, when you say a “proxy function”, do you mean an [actual JS Proxy](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy)? @tofumatt no no, not an actual proxy :) I simply meant a...

Create Proxy Event Tracking Function to Add Site Kit as Source for All ICE Events

@zutigrm > - Update includes/Modules/Ads.php > - In setup_assets method: > - If conversionInfra feature flag is enabled instantiate new Script registering the above JS file and pushing it to...

Create Proxy Event Tracking Function to Add Site Kit as Source for All ICE Events

Thanks @zutigrm IB ✅

Implement partner service for new campaign creation completed signal

@aaemnnosttv this is ready for a re review

Create `<ConversionTrackingToggle />` Component

@zutigrm lets rather update the AC here to also indicate that updates to the conversion-tracking settings should also take place within the component, not just retrieving of values.

Create `<ConversionTrackingToggle />` Component

AC ✅ moving to IB