Simon Dowdles comments

Results 52 comments of


                                            Simon Dowdles

Create `<ConversionTrackingToggle />` Component

@zutigrm we need to mention the disconnect modals as defined in the Figma designs for GA and Ads modules.

Create `<ConversionTrackingToggle />` Component

@zutigrm as per internal discussions, this dialogue context will be different for ads and ga4, but it is essentially the same thing. I'd propose perhaps we add the ability to...

Create `<ConversionTrackingToggle />` Component

@zutigrm looking at the designs again, they are actually identical across both modules, so we do not need to do anything here other than mentioned in the IB that the...

Create `<ConversionTrackingToggle />` Component

@zutigrm this LGTM, moving to EB

Integrate `<ConversionTrackingToggle />` Component Into Ads and GA4 Module `<SettingsView />` Components

AC ✅

Integrate `<ConversionTrackingToggle />` Component Into Ads and GA4 Module `<SettingsView />` Components

IB ✅

Integrate `<ConversionTrackingToggle />` Component Into Ads and GA4 `<SettingsEdit />` Components

AC ✅ Moving to IB

Adjust the CTA and "New" badge positions for widget areas on mobile and tablet viewports.

Noting as per communication with @techanvil that the implementation of this ticket needed a bit more effort and action than the IB stated, mostly due to: - There could not...

Adjust the CTA and "New" badge positions for widget areas on mobile and tablet viewports.

Also noting that due to eslint complexity violations (exceeded by 6 levels of complexity), resulting efforts included the separation of the new badge component into it's own WidgetNewBadge component, accepting...

Add full size selection panel on the new screen

@zutigrm I feel we are missing some details in the AC: - What is the expected route, should it match existing route conventions etc - What render at this route,...