Mr Ree comments

Results 9 comments of


                                            Mr Ree

Fix TOCTOU bug in unused_port module

@jimmygchen Hey new contributor here. Is it cool I work on this?

Fix TOCTOU bug in unused_port module

Went ahead and implemented first part of fix in above pull request

Do not request attestation data when attestation duty is empty

FYI the three tests are also failing for my PR: https://github.com/sigp/lighthouse/pull/8551

Enable multi node attestation consensus for the VC

Just curious are you gonna just pick one BN to get the ghost head (beacon_block_root)?

Set trace sampling as the default behavior

I got this if its cool with yall

fix: TOCTOU issue in network config

Should be good for another review

Feat: Supermajority fork protection in the VC

I'm going to work on this if everyone is ok with it.

Feat: Supermajority fork protection in the VC

"Lighthouse could be the third client a bit after." - I'm down to implement now then we can wait to merge the PR.

Feat: Supermajority fork protection in the VC

Ill start with looking at Vero's implementation and after I might have questions. The one ambiguity I have is how do we handle when the GHOST head across N agreed...