Do not request attestation data when attestation duty is empty

Open chong-he opened this issue 3 weeks ago • 1 comments

#8171 introduces a bug where the VC would call the BN for attestation_data even though there is no attestation duty. This PR fixes this by adding a check for empty duty.

Also, I think the check in sign_and_publish_attestations is now redundant so I removed it.

Thanks @eserilev for the report!

Dec 10 '25 05:12 chong-he

Some required checks have failed. Could you please take a look @chong-he? 🙏

Dec 10 '25 06:12 mergify[bot]

FYI the three tests are also failing for my PR: https://github.com/sigp/lighthouse/pull/8551

Dec 10 '25 18:12 0xmrree

yep @pawanjay176 this should fix the issue where we are fetching attestation data for every slot regardless of validator duties

Dec 10 '25 18:12 eserilev

FYI the three tests are also failing for my PR: #8551

This will be fixed by #8557

Dec 11 '25 01:12 chong-he

Merge Queue Status

✅ The pull request has been merged at 96619b1e96997cfccbfeddc326ee8e35283cfa71

This pull request spent 42 minutes 9 seconds in the queue, including 40 minutes 1 second running CI. The checks were run on draft #8565.

Required conditions to merge

[X] check-success=local-testnet-success
[X] check-success=test-suite-success

Dec 11 '25 06:12 mergify[bot]