Martin Charles

Results 63 comments of Martin Charles

Is implementation of this not completely possible in the application layer? Yes, it is hard, but I think with a `BroadcastChannel` for communication and some code intercepting mutations there's nothing...

I just realized the complexity around transaction snapshots while trying to implement it. 🤦 I guess transactions aren't structured cloned and even if they could, they'd probably be closed as...

hey hey! glad to see there's some progress on this. I'd love to get this landed. Are you looking for someone to pair with on the rust bits? Are you...

Nice! It looks like my changes are pretty similar to yours. I think the open questions from me are * Versioning. It seems like you allow specifying a min-version in...

Notes from our call * The new C API allows for specifying a version here. https://github.com/samansmink/duckdb-rs/blob/eeca07d8f7ba6c6b9a0a10f4c92c3f87e319487f/crates/libduckdb-sys/build.rs#L426 Extensions declare a minimum supported duckdb API version and duckdb returns a compatible API...

@samansmink I made a PR into your repo with bundled build working. Tagging it here in case it got lost https://github.com/samansmink/duckdb-rs/pull/1 Can't wait to get this all landed when you're...

Saw you merged the work in progress PR into your branch! Let me know if you are finding issues with it, happy to help.

I've setup a usage of the c extensions API in my project (vendored duckdb-rs) and I found a few things we missed. 1. https://github.com/0xcaff/duckdb_protobuf/blob/1a2bb08d445daa5d2400301351a7c89cc8c37fe0/patches/libduckdb-sys%2B1.0.0.patch#L102-L114 If buildtime_bindgen is disabled, and loadable_extension,...

here's what i did to get stuff working in my project btw https://github.com/0xcaff/duckdb_protobuf/pull/17

I agree. I avoided this design as it involved making a breaking change. If we're happy to break the API, I'm happy to do things this simpler way. Also, as...